[WIP] Remove legacy FIL #6603
Draft
[WIP] Remove legacy FIL #6603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hcho3
commented
Apr 29, 2025
hcho3
commented
- Remove legacy FIL from gtest
- Remove legacy FIL from the Python layer of cuML RF
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
hcho3
commented
Apr 29, 2025
Comment on lines
+242
to
+250
| // Allocate workspace and perform segmented reduce | ||
| thrust::device_vector<kv_type> workspace2( | ||
| params.n_rows + temp_storage_bytes / sizeof(kv_type) + 1); | ||
| cub::DeviceSegmentedReduce::ArgMax( | ||
| thrust::raw_pointer_cast(workspace2.data() + params.n_rows), temp_storage_bytes, | ||
| workspace->begin(), workspace2.begin(), | ||
| params.n_rows, offsets_it, offsets_it + 1); | ||
| thrust::transform(workspace2.begin(), workspace2.begin() + params.n_rows, pred->begin(), | ||
| [] __device__ (kv_type x) -> int { return x.key; }); |
There was a problem hiding this comment.
Note. The new FIL always returns probabilities for classifiers. If class outputs are desired, we need to perform argmax.
hcho3
commented
May 1, 2025
Comment on lines
+173
to
+176
| // Handle a degenerate tree with a childless root node | ||
| if (aligned_data.inner_data.distant_offset == 0) { | ||
| return offset_type{} + aligned_data.inner_data.distant_offset; | ||
| } |
There was a problem hiding this comment.
This provides a fix for a subtle memory bug. Given a degenerate tree with a single childless root node, the node struct is initialized with distant_offset = 0. When the inference kernel accesses the next node at index condition + (distant_offset - 1), it tries to access index -1, leading to out-of-bounds access.
I was able to discover the bug with the help of property-based gtests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.